Create wikis without content
What does this MR do and why?
Allows the creation of wiki pages with no content
What does this MR not do?
Remove the button disabling behavior (a disabled button shouldn't be used for validation)
Screenshots or screen recordings
N/A
How to set up and validate locally
- Go go wiki
- Create page with no content
Links
Merge request reports
Activity
changed milestone to %17.1
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
Reviewer roulette
Category Reviewer Maintainer frontend @leetickett-gitlab
(UTC+1, 1 hour ahead of author)
@pslaughter
(UTC-5, 5 hours behind author)
test for spec/features/*
@theoretick
(UTC-7, 7 hours behind author)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits eb1dfd6e and 687dfb33
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.31 MB 4.31 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for eb1dfd6e. So we have used data from: a8bb7088.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Himanshu Kapoor
@seggenberger Could you please review UX here?
@himkp Could you please review frontend?
/cc @mmacfarlane
requested review from @seggenberger and @himkp
added pipelinetier-1 label
added pipeline:mr-approved label
- Resolved by Himanshu Kapoor
@seggenberger
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-2 label and removed pipelinetier-1 label
removed review request for @seggenberger
- Resolved by Annabel Dunstone Gray
added pipelinetier-3 label and removed pipelinetier-2 label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 687dfb33expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 1 | 30 | 32 | ✅ | | Monitor | 8 | 0 | 0 | 7 | 8 | ✅ | | Govern | 64 | 0 | 1 | 41 | 65 | ✅ | | Create | 110 | 0 | 10 | 93 | 120 | ✅ | | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | | Plan | 54 | 0 | 2 | 47 | 56 | ✅ | | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 324 | 0 | 27 | 265 | 351 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
reset approvals from @himkp by pushing to the branch
- Resolved by Himanshu Kapoor
enabled an automatic merge when the pipeline for da6bb237 succeeds
reset approvals from @himkp by pushing to the branch
added 150 commits
-
8e035473...0d0a93b3 - 149 commits from branch
master
- 83355a2f - Create wikis without content
-
8e035473...0d0a93b3 - 149 commits from branch
added pipelinetier-2 label and removed pipelinetier-3 label
@himkp I had to fix some more specs; could you please re-approve/MWPS?
added 47 commits
-
83355a2f...cc9a7b5b - 46 commits from branch
master
- 687dfb33 - Create wikis without content
-
83355a2f...cc9a7b5b - 46 commits from branch
added pipelinetier-3 label and removed pipelinetier-2 label
enabled an automatic merge when the pipeline for 22e2b0e7 succeeds
mentioned in incident gitlab-org/quality/engineering-productivity/approved-mr-pipeline-incidents#265 (closed)
mentioned in commit 2def6f11
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added groupknowledge label
added devopsplan sectiondev labels
added Category:Wiki label
mentioned in issue #221061 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3098 (merged)
mentioned in issue #497419 (closed)