Skip to content

Fix dark mode hover for admin/credentials row user email

Chad Lavimoniere requested to merge 460234-dark-mode-text-secondary-gets-black-color-on-hover-2 into master

What does this MR do and why?

When the user is in dark mode, the user email link in a row in the admin/credentials dashboard turns too dark to see on hover. This MR fixes that by changing the utility class applied.

Note that the color is different, but gl-text-secondary is a more accurate/appropriate secondary text color than the bootstrap text-secondary color.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screen_Recording_2024-05-16_at_13.50.45 Screen_Recording_2024-05-16_at_13.49.50

How to set up and validate locally

  1. Check out this branch
  2. Ensure your user is using dark mode in the GDK
  3. Visit http://gdk.test:3000/admin/credentials
  4. If necessary, create a PAT
  5. When there is at least one PAT to see, hover over the email address of a user who owns a PAT
  6. The color of the email will not change at all.

Related to #460234 (closed)

Related to #452225 (closed)

Edited by Chad Lavimoniere

Merge request reports