Skip to content

Revert removal of ExclusiveLease from Users::ActivityService

Manoj M J requested to merge mmj-exclusive-lease-revert into master

What does this MR do and why?

This is a combined revert of !151342 (merged) and !152168 (merged)

We are reverting these because the removal of ExclusiveLease from this area is causing an increase in SQL queries at 00:00 UTC, which is the start of the day, and the time when we update last_activity_on for a user by updating their attribute.

It seems like the first few requests of a day for each user can be highly concurrent in nature, and leading to issue such as this: gitlab-com/gl-infra/production#18020 (comment 1908088688).

So, it is appropriate to revert this change for now and then think about other solutions.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Manoj M J

Merge request reports