Skip to content
Snippets Groups Projects

Update wiki sidebar

Merged Annabel Dunstone Gray requested to merge wiki-sidebar-truncate into master

What does this MR do and why?

  • Truncate page names
  • Remove button hover style
  • Remove double border on sidebar
  • Add button to view all pages

Screenshots or screen recordings

Before After
Screenshot_2024-05-21_at_2.55.37_PM Screenshot_2024-05-22_at_6.03.10_AM

How to set up and validate locally

Links

Edited by Annabel Dunstone Gray

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 465 commits

    Compare with previous version

  • Annabel Dunstone Gray marked this merge request as ready

    marked this merge request as ready

  • Annabel Dunstone Gray changed the description

    changed the description

  • requested review from @himkp

    • Resolved by Himanshu Kapoor

      @annabeldunstone One prominent issue with the sidebar is that it is hard to know which page is a child page and which one is a parent. Consider the page structure in your screenshot:

      Wiki page structure Rendered sidebar
      Sidebar
      ├─ A very long wiki name a very...
      ├─ RangeMap
      ├─ Caches Explained
      │  └─ Basic Utilities
      ├─ Home
      │  ├─ First step
      │  └─ Second step
      └─ test empty page

      image.png

      The above structure is just an assumption as I cannot tell if First step, Second step and test empty page are on the same level or not.

      I think the root problem here is that the chevron is to the left of a folder name, and it does not appear for a page that has no children. This can be solved easily if we align the chevron to the right. This is also how we do it on the main sidebar on the left:

      image.png

      What do you think?

      Edited by Himanshu Kapoor
  • Annabel Dunstone Gray changed the description

    changed the description

  • Annabel Dunstone Gray marked this merge request as draft

    marked this merge request as draft

  • added 231 commits

    Compare with previous version

  • added 2 commits

    • 198ab385 - Update design of wiki sidebar
    • 41343bbc - Merge branch 'more-wiki-sidebar-updates' into 'wiki-sidebar-truncate'

    Compare with previous version

  • Annabel Dunstone Gray changed the description

    changed the description

  • added 5 commits

    • a778711a - Change edit board to "Configure board"
    • 8b539122 - Update wiki sidebar
    • af2da8ad - Rename all pages -> sitemap
    • ebc7fb04 - Update design of wiki sidebar
    • 1121f5c0 - Collapse/expand items on row click

    Compare with previous version

  • A deleted user added documentation label

    added documentation label

  • added 154 commits

    Compare with previous version

  • added 1 commit

    • 70063873 - Collapse/expand items on row click

    Compare with previous version

  • added 1 commit

    • 5bd325d2 - Add sidebar header, icon edit button

    Compare with previous version

  • Annabel Dunstone Gray changed the description

    changed the description

  • added 1 commit

    • 05d0ecb7 - Add sidebar header, icon edit button

    Compare with previous version

  • Annabel Dunstone Gray marked this merge request as ready

    marked this merge request as ready

  • Himanshu Kapoor approved this merge request

    approved this merge request

  • added pipelinetier-3 label and removed pipelinetier-1 label

  • Himanshu Kapoor unapproved this merge request

    unapproved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading