Skip to content

Handle product analytics urls ending with slash

Halil Coban requested to merge handle-product-analytics-urls-with-slash into master

What does this MR do and why?

When setting the product analytics settings at either the admin or project level, if the user adds a URL to any of the URL-based settings which includes a / at the end of the URL, we see a failure. For example, the worker tries to call //setup_project/gitlab_project_x instead of /setup_project/gitlab_project_x.

This MR fixes it.

Closes #460880 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Product analytics onboarding stuck Screenshot_2024-05-15_at_16.51.34 Onboarding completes successfully Screenshot_2024-05-15_at_16.48.44

How to set up and validate locally

  1. Onboard product analytics with a configurator string ending with a slash eg: http://myusername:mypassword@localhost:4567/
  2. Onboarding should succeed
Edited by Halil Coban

Merge request reports