Ensure all time counters don't have expiry date
What does this MR do and why?
The total counter keys should not expire as that will cause us to lose data if the keys are not updated continuously.
We started expiring keys due to a bug described here: !152475 (closed)
This issue only happened on gitlab.com.
See #461381 (closed) for context.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- In the Redis CLI:
- Create a Redis key with the
{event_counters}
prefix e.g. `INCR "{event_counters}_test"`` - Set the expiry for the new key:
EXPIRE "{event_counters}_test" 10000
- Create a Redis key with the
- Apply the mirations
bundle exec rake db:migrate
- Verify that the new key has a TTL of
-1
:TTL "{event_counters}_test"
You can get inspiration for other interesting cases from the spec.
Related to #461381 (closed)
Edited by Jonas Larsen