Skip to content

Move organization mock data to fixtures

Peter Hegman requested to merge 439147-organizations-swap-mock-test-data-for-frontend-fixtures-to-improve-test-coverage-3 into master

What does this MR do and why?

Related to #439147 (closed)

The grouptenant scale team is starting to build out an Organization MVC. For more information about what an "Organization" will be see https://docs.gitlab.com/ee/architecture/blueprints/organization/

When we started building organizations we didn't have all the GraphQL queries and mutations setup so we used mock data to build the dashboard and for the specs. Now we have everything switched over to real GraphQL queries and can start removing the mock data in favor of fixtures which will help us improve test coverage. This MR adds a fixture for Mutation.organizationCreate, Mutation.organizationUpdate, and OrganizationUserConnection and uses those in the specs.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visual changes

How to set up and validate locally

  1. Run bin/rspec spec/frontend/fixtures/organizations.rb
  2. Run yarn jest spec/frontend/organizations
  3. Everything should pass 🤞
Edited by Peter Hegman

Merge request reports