Skip to content

Finalize BackupAndRemoveNotesWithNullNoteableType

Mario Celi requested to merge 443667-finalize-and-validate-contraint into master

What does this MR do and why?

Background migration finalized and we schedule the NOT NULL constraint of the notes.noteable_type column to be run over the weekend

DB review

UP

bin/rails db:migrate
main: == [advisory_lock_connection] object_id: 125240, pg_backend_pid: 23482
main: == 20240514210445 FinalizeBackupAndRemoveNotesWithNullNoteableType: migrating =
main: -- transaction_open?(nil)
main:    -> 0.0000s
main: == 20240514210445 FinalizeBackupAndRemoveNotesWithNullNoteableType: migrated (0.0283s)

main: == [advisory_lock_connection] object_id: 125240, pg_backend_pid: 23482
ci: == [advisory_lock_connection] object_id: 125540, pg_backend_pid: 23484
ci: == 20240514210445 FinalizeBackupAndRemoveNotesWithNullNoteableType: migrating =
ci: -- The migration is skipped since it modifies the schemas: [:gitlab_main_cell].
ci: -- This database can only apply migrations in one of the following schemas: [:gitlab_ci, :gitlab_internal, :gitlab_shared].
ci: == 20240514210445 FinalizeBackupAndRemoveNotesWithNullNoteableType: migrated (0.0062s)

ci: == [advisory_lock_connection] object_id: 125540, pg_backend_pid: 23484
main: == [advisory_lock_connection] object_id: 125700, pg_backend_pid: 23487
main: == 20240514214517 AsyncValidateNotesNoteableTypeNotNullConstraint: migrating ==
main: == 20240514214517 AsyncValidateNotesNoteableTypeNotNullConstraint: migrated (0.0134s)

main: == [advisory_lock_connection] object_id: 125700, pg_backend_pid: 23487
ci: == [advisory_lock_connection] object_id: 125940, pg_backend_pid: 23489
ci: == 20240514214517 AsyncValidateNotesNoteableTypeNotNullConstraint: migrating ==
ci: == 20240514214517 AsyncValidateNotesNoteableTypeNotNullConstraint: migrated (0.0096s)

ci: == [advisory_lock_connection] object_id: 125940, pg_backend_pid: 23489

DOWN

bin/rails db:rollback:main db:rollback:ci STEP=2
main: == [advisory_lock_connection] object_id: 124800, pg_backend_pid: 22790
main: == 20240514214517 AsyncValidateNotesNoteableTypeNotNullConstraint: reverting ==
main: == 20240514214517 AsyncValidateNotesNoteableTypeNotNullConstraint: reverted (0.0225s)

main: == 20240514210445 FinalizeBackupAndRemoveNotesWithNullNoteableType: reverting =
main: == 20240514210445 FinalizeBackupAndRemoveNotesWithNullNoteableType: reverted (0.0019s)

main: == [advisory_lock_connection] object_id: 124800, pg_backend_pid: 22790
ci: == [advisory_lock_connection] object_id: 132240, pg_backend_pid: 23041
ci: == 20240514214517 AsyncValidateNotesNoteableTypeNotNullConstraint: reverting ==
ci: == 20240514214517 AsyncValidateNotesNoteableTypeNotNullConstraint: reverted (0.0097s)

ci: == 20240514210445 FinalizeBackupAndRemoveNotesWithNullNoteableType: reverting =
ci: -- The migration is skipped since it modifies the schemas: [:gitlab_main_cell].
ci: -- This database can only apply migrations in one of the following schemas: [:gitlab_ci, :gitlab_internal, :gitlab_shared].
ci: == 20240514210445 FinalizeBackupAndRemoveNotesWithNullNoteableType: reverted (0.0065s)

ci: == [advisory_lock_connection] object_id: 132240, pg_backend_pid: 23041

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #443667

Edited by Mario Celi

Merge request reports