Skip to content

Fix error message when adding confidential epic to public issue

Kev Kloss requested to merge kkloss-error-message-confidential-epic-issue-mismastch into master

What does this MR do and why?

This MR fixes the error message when setting the epic of a public issue to a confidential epic via the /epic quick action. Previously, it would fail just with a “something went wrong”-style error, even though we know that only confidential issues can be added to confidential epics.

We’re checking in ee/app/models/epic_issue.rb for the aforementioned condition, which raises an EpicAssignmentError.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

  1. Create a confidential epic
  2. Create a non-confidential issue
  3. Copy the reference of the epic (e.g. group&6)
  4. Try to add the issue to the confidential epic via the /epic quick action (e.g. /epic group&6)
  5. See that it errors with a generic error message

Merge request reports