Skip to content

Fix diff comment on whitespace only change

Phil Hughes requested to merge ph/442351/diffLineCommentWhitespaceOnlyChange into master

What does this MR do and why?

Fixes a bug where a user could not leave a comment on a whitespace only change, with the Show whitespace changes checkbox unchecked and after clicking the Show changes button.

#442351 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

  • Create a change in a project that only contains whitespace changes
  • Create a new merge request from that branch
  • Make sure the Show whitespace changes is unchecked
  • Click Show changes on the diff file
  • Create a new comment

Merge request reports