Skip to content

Update the On Demand DAST E2E spec

Will Meek requested to merge dast_spec_vulnerability_update into master

What does this MR do and why?

Update the On Demand DAST E2E spec

With DAST v5.0 using Browserker as a browser based test, use a different vulnerability to test against, as it turns out the previous used one was a proxy scanning false positive.

See discussion at https://gitlab.com/gitlab-org/gitlab/-/issues/461031#note_1900460408

Briefly investigated using DVWA - #461221 (closed) - however ran into the issue whereby it wants to run against localhost which our runner cannot find (to scan against).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a - some screenshots of scanner functionality before/after conversion to Browserker at https://gitlab.com/gitlab-org/gitlab/-/issues/461031

How to set up and validate locally

bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/ee/browser_ui/13_secure/on_demand_dast_spec.rb

Merge request reports