Draft: Clean up specs

What does this MR do and why?

Cleans up some specs as outlined in this issue: Follow-up from "Secrets push check uses project... (#460011) • rossfuhrman • 17.2 • On track

Also address this feedback:

question: would it be more explicit to expect that we never call ::Gitlab::SecretDetection::Scan#secrets_scan? It looks like there are other ways for the method to return nil and we're explicitly hoping it doesn't run the scan.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.