Skip to content

Remove log_execution_time_path_traversal_middleware feature flag

David Fernandez requested to merge 457759-remove-feature-flag into master

🎱 Context

As part of https://gitlab.com/groups/gitlab-org/-/epics/13437, we introduced a new middleware that would run additional checks on requests that go through.

One important aspect of the middleware was to measure the impact on the overall latency. We did this in https://gitlab.com/gitlab-org/gitlab/-/issues/415460#note_1877088135.

Now that the analysis is over, we can cleanup the related feature flag and the associated code.

Please note that the middleware is still behind a general feature flag. We are thus removing a feature flag within a feature flag. This is issue #457759+.

🔬 What does this MR do and why?

  • Remove log_execution_time_path_traversal_middleware feature flag.
  • Remove code behind that feature flag.
  • Update the related spec.

🏁 MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

✅

🌈 Screenshots or screen recordings

None

⚙ How to set up and validate locally

See !133465 (merged). We will not log the duration_ms field anymore.

Merge request reports