Skip to content

Add test functionality for unsaved group integrations

Ben King requested to merge benjaminking-jira-group-test into master

What does this MR do and why?

Currently, group-level integrations that support being 'testable' (only Jira?), will always fall when pressing 'Test settings' because we don't actually make a callout to a test function. This MR uses the same functionality as the project-level integrations by adding #test to Groups::Settings::IntegrationsController, which in turn calls integration_test_response. There is already existing functionality in Integrations::Test::GroupService to handle the test.

Resolves #461000

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

The following example should return a failure message that the URL cannot be resolved. The first test in Before is taken from GitLab.com. After is in GDK with these changes applied.

Before After
gitlabcom-int-test gdk-int-test

How to set up and validate locally

  1. Use an existing group, or create a new top-level group.
  2. Go to SettingsIntegrations, and select Jira.
  3. Use either a valid Atlassian Jira server, or a fake URL, to confirm that the test now properly performs the callout.
Edited by Ben King

Merge request reports