Skip to content

Draft: Add Full & Partial Reconciliation Interval From Rails To Agent

Issue - #460416 (comment 1900197534)+

What does this MR do and why?

We add in validation on full & partial interval seconds, making sure no invalid data is leak into all downstreamings. This is down in the settings module.

Also we pass in those 2 envs from settings into reconcilation flow, and send them to agent via our API.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before this, there is no validation on instance vars, which means the user could set potentially any values, which will cause other issues later

Success Case Screenshot_2024-05-13_at_1.35.08_PM

Incorrect input values, validation fails

Negative or Zero Full Interval Screenshot_2024-05-13_at_1.36.42_PM

Negative or Zero Partial Interval Screenshot_2024-05-13_at_1.37.54_PM

Partial greater or equal than Full Screenshot_2024-05-13_at_1.38.56_PM

Full MR local test. We could see the new two fields are included into the response payload

Screenshot_2024-05-14_at_12.06.37_PM

When there is validation error with either fields, there would be runtime error raised, and no reconciliation happen

Screenshot_2024-05-14_at_12.07.41_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Zhaochen Li

Merge request reports

Loading