Skip to content
Snippets Groups Projects

Add request_accepted_at column to the members table

  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

Add request_accepted_at column to the members table

Later we will use this column to implement logic to display a correct access given date

Related to: #24721 (closed)

Changelog: added

Screenshots or screen recordings

No screenshots needed

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I have reviewed the merge request and left comments on the code. I asked the author to add a test for the change and to update the structure.sql changes to include only the required changes, as the current version contains lots of irrelevant changes. I estimate that a small amount of work is required to address these comments.

  • Pavel Shutsin requested changes

    requested changes

  • George Koltsov removed review request for @georgekoltsov

    removed review request for @georgekoltsov

  • added 1 commit

    • 71fed976 - Made 'request_accepted_at' field nullable, add test example

    Compare with previous version

  • Anton Kalmykov added 261 commits

    added 261 commits

    • 71fed976...256ebbad - 258 commits from branch gitlab-org:master
    • 0d82985b - Merge branch 'master' into 24721_Members_given_access_date_time_is_wrong
    • c5dadbc9 - Merge branch 'master' into 24721_Members_given_access_date_time_is_wrong
    • 451a7c20 - Remove all irrelevant changes in the structure.sql

    Compare with previous version

  • Pavel Shutsin approved this merge request

    approved this merge request

  • Pavel Shutsin removed review request for @pshutsin

    removed review request for @pshutsin

  • added pipelinetier-3 label and removed pipelinetier-2 label

  • George Koltsov approved this merge request

    approved this merge request

  • Rajendra Kadam
  • I have a question and a suggestion.

  • John Mason removed review request for @johnmason

    removed review request for @johnmason

  • Hi @johnmason :wave:

    We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.

    @antonkalmykov you may also request a review by commenting @gitlab-bot ready. You can also assign reviewers directly using @gitlab-bot ready @user1 @user2 if you know the relevant reviewer(s), such as those who were involved in a related issue.

    This message was generated automatically. You're welcome to improve it.

  • Christina Lohr changed milestone to %17.1

    changed milestone to %17.1

  • added 1 commit

    • a736b163 - Update spec example to check request accepted field contains a timestamp

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading