Add request_accepted_at column to the members table
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do and why?
Add request_accepted_at column to the members table
Later we will use this column to implement logic to display a correct access given date
Related to: #24721 (closed)
Changelog: added
Screenshots or screen recordings
No screenshots needed
Merge request reports
Activity
Thanks for your contribution to GitLab @antonkalmykov!
- If you need help, comment @gitlab-bot help or come say hi on Discord.
- When you're ready for a review, comment on this merge request with @gitlab-bot ready.
- We welcome AI-generated contributions! Read more/check the box at the top of the merge request description.
- To add labels to your merge request, comment @gitlab-bot label ~"label1" ~"label2".
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @antonkalmykov
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
Hi Coach
@dmishunov
, this Community contribution is ready for review or needs your coaching.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
requested review from @dmishunov
added linked-issue label
5 Warnings f31d314d: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. de2785f2: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. d37159ab: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 617be644: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Category Reviewer Maintainer backend @dbiryukov
(UTC+2)
@rkadam3
(UTC+5.5)
database @johnmason
(UTC-4)
@pshutsin
(UTC+2)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Danger BotSome labels are not valid: databasereview pending
added backend database featureaddition typefeature labels
- Resolved by Rajendra Kadam
@antonkalmykov, unfortunately, I don't have expertise here to provide a qualified review. @akotte, could you please help reviewing this Community contribution MR?
Also, @johnmason, could you please review the database changes?
requested review from @akotte and @johnmason and removed review request for @dmishunov
changed milestone to %17.0
mentioned in issue gitlab-org/quality/triage-reports#17705 (closed)
added groupproject management label
added Category:Team Planning devopsplan sectiondev labels
added pipeline:mr-approved label
- Resolved by Rajendra Kadam
@johnmason
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-2 label
- Resolved by Pavel Shutsin
requested review from @pshutsin
added 631 commits
-
aef4e91b...b632f625 - 630 commits from branch
gitlab-org:master
- 811c3e6e - Merge branch 'master', resolve conflicts
-
aef4e91b...b632f625 - 630 commits from branch
reset approvals from @johnmason by pushing to the branch
requested review from @georgekoltsov
removed review request for @akotte
- Resolved by Pavel Shutsin
I have reviewed the merge request and left comments on the code. I asked the author to add a test for the change and to update the
structure.sql
changes to include only the required changes, as the current version contains lots of irrelevant changes. I estimate that a small amount of work is required to address these comments.- Resolved by Rajendra Kadam
removed review request for @georgekoltsov
added 1 commit
- 71fed976 - Made 'request_accepted_at' field nullable, add test example
added 261 commits
-
71fed976...256ebbad - 258 commits from branch
gitlab-org:master
- 0d82985b - Merge branch 'master' into 24721_Members_given_access_date_time_is_wrong
- c5dadbc9 - Merge branch 'master' into 24721_Members_given_access_date_time_is_wrong
- 451a7c20 - Remove all irrelevant changes in the structure.sql
Toggle commit list-
71fed976...256ebbad - 258 commits from branch
added databaseapproved label
removed review request for @pshutsin
added pipelinetier-3 label and removed pipelinetier-2 label
- Resolved by Rajendra Kadam
- Resolved by Rajendra Kadam
removed review request for @johnmason
Hi @johnmason
We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.
@antonkalmykov you may also request a review by commenting
@gitlab-bot ready
. You can also assign reviewers directly using@gitlab-bot ready @user1 @user2
if you know the relevant reviewer(s), such as those who were involved in a related issue.This message was generated automatically. You're welcome to improve it.
added workflowin dev label and removed workflowready for review label
changed milestone to %17.1
added 1 commit
- a736b163 - Update spec example to check request accepted field contains a timestamp