Skip to content

Remove pool_key label in connection pool metrics

Sylvester Chin requested to merge sc1-fix-remove-pool-key-label into master

What does this MR do and why?

This MR removes the pool_key label in connection pool metrics.

This fix optimises the cardinality of gitlab_connection_pool_available_count and gitlab_connection_pool_size gauges. pool_key is derived from the object_id of ConnectionPool's internal variable. We can do without it.

See gitlab-com/gl-infra/scalability#3499 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports