Ensure only one deployment run at once on release-environment
What does this MR do and why?
To prevent simultaneous execution of deploy
and qa
jobs in a release environment, the deploy
and qa
jobs triggered by the first pipeline will take precedence. Meanwhile, the deploy
and qa
jobs of subsequent pipelines will remain Waiting until the corresponding jobs in the first pipeline are completed.
Related Issue: gitlab-com/gl-infra/delivery#20008 (comment 1896145520)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @madelacruz
5 Warnings 553846f9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. b27eb9b5: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 976b6e81: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 1251829b: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Category Reviewer Maintainer ~"Pipeline configuration" Reviewer review is optional for ~"Pipeline configuration" @nao.hashizume
(UTC-7)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Mawreen Dela Cruz
Proper labels assigned to this merge request. Please ignore me.
@madelacruz - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added typemaintenance label
added groupdelivery label
added Category:Delivery devopsplatforms sectionplatforms labels
added 1 commit
- 976b6e81 - Update the token used in updating the resource_group and make the deploy and...
requested review from @dat.tang.gitlab
Hi @dat.tang.gitlab, for your review and approval. Thank you!
- Resolved by Dat Tang
- Resolved by Mawreen Dela Cruz
- Resolved by Mawreen Dela Cruz
Nice work @madelacruz . I have some comments
added 1 commit
- b27eb9b5 - Use workflow:auto_cancel:on_new_commit instead of interruptible to control...
added pipelinetier-1 label
requested review from @dat.tang.gitlab
Looks good to me
Thanks for the work @madelacruz . We have learned a lot about GitLab CIadded pipeline:mr-approved label
- Resolved by Rémy Coutable
@dat.tang.gitlab
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-2 label and removed pipelinetier-1 label
requested review from @rymai
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 553846f9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Verify | 31 | 0 | 1 | 30 | 32 | ✅ | | Create | 101 | 0 | 9 | 94 | 110 | ✅ | | Plan | 51 | 0 | 2 | 47 | 53 | ✅ | | Govern | 66 | 0 | 0 | 43 | 66 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | | Monitor | 7 | 0 | 0 | 7 | 7 | ✅ | | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 313 | 0 | 25 | 268 | 338 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Rémy Coutable
Hi @rymai, good day! Could you please take a look at this MR? Thank you!
- Resolved by Mawreen Dela Cruz
- Resolved by Mawreen Dela Cruz
removed review request for @rymai
reset approvals from @dat.tang.gitlab by pushing to the branch
Hi @dat.tang.gitlab, I have added a small change to this MR following @rymai review suggestions. Could you take a look as well? Thank you!
Edited by Mawreen Dela Cruzremoved pipeline:mr-approved label
added pipelinetier-1 label and removed pipelinetier-2 label
requested review from @rymai
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
requested review from @splattael and removed review request for @rymai
requested review from @rymai and removed review request for @splattael
added pipelinetier-3 label and removed pipelinetier-2 label
enabled an automatic merge when the pipeline for 553846f9 succeeds
@rymai, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit c17ecf23
changed milestone to %17.1
@madelacruz : looks like
before_script
is not available for trigger job https://gitlab.com/gitlab-org/gitlab/-/pipelines/1291624102.We have to revert this change.
Hi @dat.tang.gitlab, what will happen now that this is reverted? Do I need to reopen the issue?
Edited by Mawreen Dela CruzYes I reopened the issue
mentioned in commit 43955841
mentioned in merge request !153104 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in commit 8cd1745e
mentioned in merge request !153370 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label