Skip to content

Fix Faker deprecation

Heinrich Lee Yu requested to merge hly-fix-faker-deprecation into master

What does this MR do and why?

FFaker::Animal.common_name is now deprecated and moved to FFaker::AnimalUS.common_name

See https://www.rubydoc.info/github/ffaker/ffaker/FFaker/Animal#common_name-instance_method

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Run bin/rspec spec/services/ml/create_candidate_service_spec.rb
  2. Verify that no deprecation messages are printed out
Edited by Heinrich Lee Yu

Merge request reports