Skip to content

Fix flow metrics handling of null assignees

charlie ablett requested to merge 432501-cablett-issue-count-null into master

What does this MR do and why?

!151639 (merged) but fixes another one of the missing null handlers.

See https://gitlab.com/gitlab-com/dev-sub-department/section-dev-request-for-help/-/issues/172 context.

When issue analytics GraphQL query is made, most arguments are required: false 👉 https://gitlab.com/gitlab-org/gitlab/-/blob/33acb9d27c2cdd6821114c7be8d07e33bafeca0c/app/graphql/resolvers/analytics/cycle_analytics/base_issue_resolver.rb#L10

The following query is considered valid:

query {
  group(fullPath: "gitlab-org") {
    flowMetrics {
      issuesCompletedCount(
        assigneeUsernames: null
        from: "2022-01-01"
        to: "2022-02-02"
      ) {
        value
      }
    }
  }
}

However, it results in a 500 error. It fails because of this line: https://gitlab.com/gitlab-org/gitlab/-/blob/9ea00673cd08f18bce685310800522f029f580f6/app/graphql/resolvers/analytics/cycle_analytics/issue_count_resolver.rb#L25 where the argument is only removed if it has a value.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #432501 (closed)

Merge request reports