Expose project settings in REST API only for maintainer+ users
What does this MR do and why?
Expose project settings in REST API only for maintainer+ users
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- Add a user to as a Guest to a project.
- Create a personal access token as that user and then query the REST API
curl --header "Authorization: Bearer <ACCESS-TOKEN>" "http://127.0.0.1:3000/api/v4/projects/<PROJECT_ID>"
- You shouldn't see any project settings.
- However, if you upgraded that user to the Maintainer of the project, you should see all the project settings
Related to #442899 (closed)
Merge request reports
Activity
changed milestone to %17.0
assigned to @hmehra
- A deleted user
added backend label
3 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request is quite big (695 lines changed), please consider splitting it into multiple merge requests. 943f9850: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer backend @krasio
(UTC+12, 2 hours ahead of author)
@nbelokolodov
(UTC+12, 2 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 6e433a60 - Expose project settings in REST API only for maintainer+ users
added 1 commit
- 2e50c884 - Expose project settings in REST API only for maintainer+ users
added 1 commit
- 26692806 - Expose project settings in REST API only for maintainer+ users
added 1 commit
- cf6ef034 - Expose project settings in REST API only for maintainer+ users
added 299 commits
-
cf6ef034...fbd3f280 - 298 commits from branch
master
- ead88afe - Expose project settings in REST API only for maintainer+ users
-
cf6ef034...fbd3f280 - 298 commits from branch
added 1 commit
- 2382ef0b - Expose project settings in REST API only for maintainer+ users
added 1 commit
- abf39cc7 - Expose project settings in REST API only for maintainer+ users
requested review from @ibaum
- Resolved by Dmitry Gruzd
added pipeline:mr-approved label
added pipeline:mr-approved label
- Resolved by Dmitry Gruzd
@ibaum
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
changed milestone to %17.1
added workflowin review label and removed workflowin dev label
enabled an automatic merge when all merge checks for abf39cc7 pass
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 943f9850expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | | Verify | 31 | 0 | 1 | 30 | 32 | ✅ | | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Govern | 66 | 0 | 0 | 43 | 66 | ✅ | | Monitor | 8 | 0 | 0 | 7 | 8 | ✅ | | Create | 111 | 0 | 9 | 94 | 120 | ✅ | | Plan | 54 | 0 | 2 | 47 | 56 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 327 | 0 | 25 | 268 | 352 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 943f9850expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 121 | 0 | 5 | 1 | 126 | ✅ | | Create | 297 | 0 | 31 | 0 | 328 | ✅ | | Plan | 22 | 0 | 2 | 0 | 24 | ✅ | | Data Stores | 11 | 0 | 0 | 0 | 11 | ✅ | | Package | 3 | 0 | 4 | 0 | 7 | ✅ | | Verify | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 1 | 0 | 0 | 0 | 1 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 464 | 0 | 42 | 1 | 506 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
removed review request for @dgruzd
added pipelinetier-3 label
added 1461 commits
-
abf39cc7...80a45103 - 1460 commits from branch
master
- 23c64855 - Expose project settings in REST API only for maintainer+ users
-
abf39cc7...80a45103 - 1460 commits from branch
reset approvals from @dgruzd by pushing to the branch
added pipelinetier-2 label and removed pipelinetier-3 label
- Resolved by Dmitry Gruzd
added 442 commits
-
fcefac54...4a39e2ac - 440 commits from branch
master
- 609b62bd - Expose project settings in REST API only for maintainer+ users
- 943f9850 - Fix failures in project's grape entity
-
fcefac54...4a39e2ac - 440 commits from branch
requested review from @dgruzd
added pipelinetier-3 label and removed pipelinetier-2 label
enabled an automatic merge when the pipeline for 96d96119 succeeds
mentioned in commit 8342ab49
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label