Skip to content

Remove needs and dependencies from Code Quality template

Sanad Liaquat requested to merge tti-shl-remove-needs-and-dependencies-from-code-quality-template into master

What does this MR do and why?

  • needs: [] results in the jobs starting as soon as the pipeline is created.
  • dependencies: [] prevents the job from downloading any artifacts.

We have a use case where we need to run Code Quality scans on artifacts produced in an earlier stage and the Code Quality template sets both values to []. There seems no way to unset the values. We could override them with earlier stage jobsthat produces the artifacts but the documentation prevents/discourages from using both needs and dependencies in one job:

Additional details:

  • You should not combine needs with dependencies in the same job.

See relevant discussion here: https://gitlab.com/gitlab-org/quality/comparator/-/merge_requests/29#note_1892568066

With this change, we are removing needs: [] and dependencies: []. Any project that require them to be set as such can override the values.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Sanad Liaquat

Merge request reports