Skip to content

Refactor i18n code in issues list code

Coung Ngo requested to merge cngo-refactor-i18n-issues-list into master

What does this MR do and why?

Refactor i18n code in issues list code

  • Move translations into template for better readability
  • Replace test assertions with string literals for better readability and robustness

There was a recent discussion in #frontend with the sentiment that $options.i18n.myLabelText everywhere in the template can hurt readability because there's a lot of jumping about in code to see what the actual UI text is, and it can be difficult working with the code alongside the UI when the UI text is far away from the template. I definitely find this is the case for a bunch of these UI texts in this MR

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visual changes

How to set up and validate locally

  1. Go to an issues list and check everything works as expected (e.g. http://127.0.0.1:3000/flightjs/flight/-/issues/)
Edited by Coung Ngo

Merge request reports