Skip to content

Preserve approval rules when role changes

Sincheol (David) Kim requested to merge 454269-upgrading-role-of-member-will-remove-them-from-approval-rules into master

What does this MR do and why?

This MR fixes the bug which causes the user to be removed from approval rules when the user's role gets changed.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Add member as Maintainer of project.
  2. Add member as approver of an approval rule.
  3. Create a MR.
  4. Update role of member (via API or web UI).
  5. Refresh MR and see that the member will NOT be removed from approval rule. This can also be seen on the project settings as the user will also be NOT removed from project-level rule.

Related to #454269 (closed)

Edited by Sincheol (David) Kim

Merge request reports