Skip to content

Separate Bitbucket Server Importers Logic - Part 2

  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

See full context in !149302

This is Part 2 from a series of MRs to handle issues: #451129.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
MR List:
Screenshot_2024-05-03_at_17.04.20
Approved Event:
Screenshot_2024-05-03_at_17.04.39
Standalone Comments:
Screenshot_2024-05-03_at_17.05.13
Inline Comments:
Screenshot_2024-05-03_at_17.05.47
Merge Event:
Screenshot_2024-05-03_at_17.06.06
New Importer Class:
Screenshot_2024-05-03_at_17.07.05

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Initial environment setup can follow this
  2. Prepare some data in Bitbucket Server
  3. Patch the code to inject interruption:
diff --git a/gems/gitlab-http/lib/gitlab/http_v2/url_blocker.rb b/gems/gitlab-http/lib/gitlab/http_v2/url_blocker.rb
index 99876c779539..06bd0c6b92cd 100644
--- a/gems/gitlab-http/lib/gitlab/http_v2/url_blocker.rb
+++ b/gems/gitlab-http/lib/gitlab/http_v2/url_blocker.rb
@@ -64,6 +64,9 @@ def validate_url_with_proxy!(
         )
           # rubocop:enable Metrics/ParameterLists
 
+          allow_localhost = true
+          allow_local_network = true
+
           return Result.new(nil, nil, true) if url.nil?
 
           raise ArgumentError, 'The schemes is a required argument' if schemes.blank?
  1. Tail the log file: tail -f log/importer.log
  2. Go to http://127.0.0.1:3000/import/bitbucket_server/status
  3. Click Import
Edited by Ivan Sebastian

Merge request reports