Protected packages: Use icon only for delete rule button
requested to merge gitlab-community/gitlab:413641-gerardo-navarro-protected-packages-project-settings-ui-delete-follow-up-delete-rule-button-with-icon-only into master
What does this MR do and why?
- Aligning the UX design concepts for the sections "Protected packages" and "Protected containers", see !150793 (merged)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
 |
|
 |
 |
How to set up and validate locally
- In rails console enable the experiment fully
Feature.enable(:packages_protected_packages)- Add some package protection rules
15.times { |i| Packages::Protection::Rule.create(project: Project.find_by_full_path('flightjs/Flight'), package_name_pattern: "@flightjs/flight-package-#{i}", package_type: :npm, push_protected_up_to_access_level: :maintainer) }- Go to http://gdk.test:3000/flightjs/Flight/-/settings/packages_and_registries
- Start deleting protection rules by clicking the button "Delete"
Ref #413641
Edited by Gerardo Navarro