Skip to content

Adapt Group policy to use runner_performance_insights_for_namespace

Pedro Pombeiro (OOO on the week of Oct 14th-18th) requested to merge pedropombeiro/459984/use-runner_performance_insights_for_namespace into master

What does this MR do and why?

This MR adapts the Group policy to use the new runner_performance_insights_for_namespace feature instead of runner_performance_insights. RunnerResolver is adapted so that it checks runner_performance_insights_for_namespace on the group, if being used from inside a group. The MR also refactors the RunnerResolver specs, which were in a messy state.

note: I'd advise a good text compare tool (such as Beyond Compare) which allows custom line alignment to review the changes in ee/spec/requests/api/graphql/ci/runners_spec.rb.

EE: true

Closes #459984 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

I'm basing myself on the existing test coverage here.

Edited by Pedro Pombeiro (OOO on the week of Oct 14th-18th)

Merge request reports