Skip to content

Add alternate route for Markdown uploads

Heinrich Lee Yu requested to merge hly-banzai-uploads-route into master

What does this MR do and why?

Add route based on project or group IDs instead of project or group paths.

So if you have an upload like: https://gitlab.com/gitlab-org/gitlab/uploads/<secret>/somefile.txt, it can also be accessed via the URL: https://gitlab.com/-/project/278964/uploads/<secret>/somefile.txt.

For group-level uploads it will be: https://gitlab.com/-/group/9970/uploads/<secret>/somefile.txt

In a future MR, we will change the URLs generated from Markdown uploads to use this new format. We do this to lower the legitimacy of user upload links specially for popular project paths.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Upload a file to an issue / epic
  2. Manually visit the new upload URL format
Edited by Heinrich Lee Yu

Merge request reports