Ensure to run all rails logic when deleting pages deployments

What does this MR do and why?

Ensure to run all rails logic when deleting pages deployments

The usage of delete_all caused problems in the past where the operation wasn't deleting the deployment files.

To ensure we're calling all rails callbacks while deleting pages deployments, it's better to use destroy!.

Related to: #457159 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

changed milestone to %17.0

added Category:Pages devopsplan groupknowledge maintenancerefactor sectiondev typemaintenance labels

assigned to @kassio

mentioned in issue #457159 (closed)

added backend label

Reviewer roulette

Category	Reviewer	Maintainer
backend	@tigerwnz (UTC+10, 9 hours ahead of author)	@johnmason (UTC-4, 5 hours behind author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@adie.po, could you do the review of this one, please?

requested review from @adie.po

approved this merge request

added pipeline:mr-approved label

@adie.po, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

requested review from @iamricecake

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 21bc7359

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 51     | 0      | 2       | 47    | 53    | ✅     |
| Package     | 19     | 0      | 12      | 19    | 31    | ✅     |
| Data Stores | 31     | 0      | 0       | 22    | 31    | ✅     |
| Create      | 101    | 0      | 9       | 94    | 110   | ✅     |
| Govern      | 66     | 0      | 0       | 43    | 66    | ✅     |
| Verify      | 31     | 0      | 1       | 30    | 32    | ✅     |
| Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
| Release     | 5      | 0      | 0       | 5     | 5     | ✅     |
| Monitor     | 7      | 0      | 0       | 7     | 7     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 313    | 0      | 25      | 268   | 338   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 21bc7359

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 285    | 0      | 23      | 0     | 308   | ✅     |
| Create      | 183    | 0      | 20      | 0     | 203   | ✅     |
| Govern      | 28     | 0      | 0       | 0     | 28    | ✅     |
| Package     | 6      | 0      | 8       | 0     | 14    | ✅     |
| Data Stores | 22     | 0      | 0       | 0     | 22    | ✅     |
| Verify      | 10     | 0      | 0       | 0     | 10    | ✅     |
| Release     | 2      | 0      | 0       | 0     | 2     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 544    | 0      | 51      | 0     | 595   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

approved this merge request

resolved all threads

enabled an automatic merge when all merge checks for 21bc7359 pass

Generated by gitlab_quality-test_tooling.

---

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#6803175283	spec/features/admin/admin_mode/workers_spec.rb#L40	Admin mode for workers as an admin user when admin mode enabled can delete user	103.25 s	< 50.13 s

added rspec:slow test detected label

merged

mentioned in commit c2b357bf

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added releasedcandidate label

picked the changes into the branch cherry-pick-c2b357bf with commit 4b973012

mentioned in commit 4b973012

picked the changes into the branch cherry-pick-c2b357bf-2 with commit c9c05fbc

mentioned in commit c9c05fbc

mentioned in merge request !153010 (merged)

picked the changes into the branch cherry-pick-c2b357bf-3 with commit 2a70b9f9

mentioned in commit 2a70b9f9

mentioned in merge request !153011 (merged)

mentioned in merge request !153012 (merged)

mentioned in commit d81093d7

picked the changes into the branch cherry-pick-c2b357bf-4 with commit 13418357

mentioned in commit 13418357

picked the changes into the branch cherry-pick-c2b357bf-5 with commit 19b97c62

mentioned in commit 19b97c62

mentioned in merge request !154838 (merged)

mentioned in issue gitlab-com/www-gitlab-com#34902 (closed)

added releasedpublished label and removed releasedcandidate label

added pipelinetier-3 label