Skip to content

Ensure to run all rails logic when deleting pages deployments

Kassio Borges requested to merge kassio/ensure-to-use-rails-logic-while-deleting-pages-deployments into master

What does this MR do and why?

Ensure to run all rails logic when deleting pages deployments

The usage of delete_all caused problems in the past where the operation wasn't deleting the deployment files.

To ensure we're calling all rails callbacks while deleting pages deployments, it's better to use destroy!.

Related to: #457159

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports