Skip to content

Flaky Test ee/spec/lib/gitlab/search/zoekt/client_spec.rb

Ravi Kumar requested to merge 458928-test-ee-spec-lib-gitlab-search-zoekt-client_spec-rb-gitlab-search-zoekt-client-delete into master

What does this MR do and why?

Change the approach of testing delete. Instead of testing if files are deleted now just testing that the delete action has sent an HHTP request to the Zoekt indexer. The actual files are deleted by the Zoekt indexer, which is not the Rails responsibility.

The second change is I have removed the backoff test for the delete and index. It is already removed from the code in this MR: Remove node backoffs for deletion and indexing ... (!140806 - merged)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #458928 (closed)

Edited by Ravi Kumar

Merge request reports