Rename approval rule
Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/65631
Documentation update: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31995/diffs
CE Port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32034
What does this MR do?
The change is to improve the user understanding of the form workflow by:
- Rename “Name” field to “Rule name”.
- Move field help text to field placeholder.
Kudos
Thank you to our community contributor @edstub207 for helping out with this feature
Test Case
-
Go go a merge request edit page
-
In the "Approver " row, click "Edit" to trigger "Update approvers" modal
-
There is a field called "Rule Name"
- In the "Approvers" row, click "Add approvers" to trigger "Add approvers" modal
-
There is a field called "Rule Name"
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Samantha Ming