Skip to content

Ensure we generate predictive pipeline if we run any predictive

Lin Jen-Shin requested to merge 453973-fix-db-predictive-when-core-changed into master

What does this MR do and why?

Ensure we generate predictive pipeline if we run any predictive pipelines

This fixes the following case:

  • Changes in both db-patterns and core-backend-patterns before approval

Before this fix, we wanted to run db-predictive but we didn't run regular predictive, which caused it to not generate the pipeline the db-predictive needed.

This was reported at #453973 (comment 1884507794)

How to validate

This was tested at !151377 (closed) where we can see the pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/1271999444

  • Run regular rspec because it changes core-backend-patterns which we made it run regular rspec instead of predictive even before approval
  • Run predictive single-db rspec because it also added migrations which touch db-patterns

Related to #453973 (closed)

Edited by Lin Jen-Shin

Merge request reports