Skip to content

Use MIN_SCHEMA_GITLAB_VERSION in keep for finalizing migrations

Dylan Griffith requested to merge batched-background-migration-keep-use-min-schema-gitlab-version into master

What does this MR do and why?

The OverdueFinalizeBackgroundMigration keep is a script that is run in CI for generating merge requests to finalize batched background migrations.

Per our documentation we can only finalize a batched background migration added before the last "required stop" which is the minimum versin someone must upgrade to before they can upgrade to this version of the code.

We were hardcoding that version in the keep before but now we have MIN_SCHEMA_GITLAB_VERSION which is exactly for this purpose we don't need to hardcode it anymore. We also changed from < to <= now that this version refers to the version of the last required stop rather than the first version after it.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Dylan Griffith

Merge request reports