Skip to content
Snippets Groups Projects

Fix Lint/AmbiguousOperatorPrecedence 4 offenses

All threads resolved!
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

Fix Lint/AmbiguousOperatorPrecedence 4 offenses

Changelog: other EE: true

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Merged results pipeline #1310734321 passed

Pipeline: [diff_match_patch gem] Ruby 3.1 pipeline

#1310734670

    Pipeline: [gitlab-http gem] Ruby 3.1 pipeline

    #1310734724

      Pipeline: [omniauth_crowd gem] Ruby 3.1 pipeline

      #1310734666

        +27

        Merged results pipeline passed for edec1835

        Test coverage 81.14% (16.82%) from 2 jobs
        Approval is optional

        Merged by Jarka KošanováJarka Košanová 9 months ago (May 29, 2024 9:06pm UTC)

        Merge details

        • Changes merged into with 5e79752f.
        • Deleted the source branch.

        Pipeline #1310948249 passed

        Pipeline passed for 5e79752f on master

        Test coverage 64.32% (16.82%) from 2 jobs
        10 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
      • added backend label

      • Archish Thakkar added 5101 commits

        added 5101 commits

        • 22310fd1...a4eff1b5 - 5099 commits from branch gitlab-org:master
        • 4dc27cdb - Merge branch 'master' of gitlab.com:gitlab-community/gitlab into...
        • ee9eacc4 - Merge branch 'master' of gitlab.com:gitlab-community/gitlab into...

        Compare with previous version

      • 1 Warning
        :warning: You've made some app changes, but didn't add any tests.
        That's OK as long as you're refactoring existing code,
        but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

        Reviewer roulette

        Category Reviewer Maintainer
        backend @janis profile link current availability (UTC+2) @eduardobonet profile link current availability (UTC+2)
        ~"Tooling" Reviewer review is optional for ~"Tooling" @splattael profile link current availability (UTC+2)
        groupauthorization Reviewer review is optional for groupauthorization @jarka profile link current availability (UTC+2)

        Please check reviewer's status!

        • available Reviewer is available!
        • unavailable Reviewer is unavailable!

        Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

        If needed, you can retry the :repeat: danger-review job that generated this comment.

        Generated by :no_entry_sign: Danger

        Edited by Danger Bot
      • requested review from @daniel-murphy

      • requested review from @eduardobonet

      • Daniel Murphy removed review request for @daniel-murphy

        removed review request for @daniel-murphy

      • Daniel Murphy changed milestone to %17.1

        changed milestone to %17.1

      • Eduardo Bonet approved this merge request

        approved this merge request

      • requested review from @hmehra, @ddieulivol, and @nao.hashizume

      • added pipelinetier-2 label and removed pipelinetier-1 label

      • David Dieulivol approved this merge request

        approved this merge request

      • Nao Hashizume approved this merge request

        approved this merge request

      • Nao Hashizume requested review from @jayswain and removed review request for @hmehra

        requested review from @jayswain and removed review request for @hmehra

      • Nao Hashizume removed review request for @nao.hashizume

        removed review request for @nao.hashizume

      • Jay approved this merge request

        approved this merge request

      • added pipelinetier-3 label and removed pipelinetier-2 label

      • Eduardo Bonet resolved all threads

        resolved all threads

      • 3 Warnings
        :warning: 43af5584: The commit subject must not start with a space. For more information, take a look at our Commit message guidelines.
        :warning: This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits.
        :warning: You've made some app changes, but didn't add any tests.
        That's OK as long as you're refactoring existing code,
        but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

        Reviewer roulette

        Category Reviewer Maintainer
        backend @janis profile link current availability (UTC+2) @eduardobonet profile link current availability (UTC+2)
        ~"Tooling" Reviewer review is optional for ~"Tooling" @ddieulivol profile link current availability (UTC+2)
        groupauthorization Reviewer review is optional for groupauthorization @alexbuijs profile link current availability (UTC+2)

        Please check reviewer's status!

        • available Reviewer is available!
        • unavailable Reviewer is unavailable!

        Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

        If needed, you can retry the :repeat: danger-review job that generated this comment.

        Generated by :no_entry_sign: Danger

      • E2E Test Result Summary

        allure-report-publisher generated test report!

        e2e-test-on-gdk: :white_check_mark: test report for a7b0215b

        expand test summary
        +------------------------------------------------------------------+
        |                          suites summary                          |
        +-------------+--------+--------+---------+-------+-------+--------+
        |             | passed | failed | skipped | flaky | total | result |
        +-------------+--------+--------+---------+-------+-------+--------+
        | Plan        | 54     | 0      | 2       | 47    | 56    | ✅     |
        | Verify      | 30     | 0      | 2       | 29    | 32    | ✅     |
        | Package     | 19     | 0      | 12      | 19    | 31    | ✅     |
        | Create      | 125    | 0      | 10      | 93    | 135   | ✅     |
        | Govern      | 64     | 0      | 1       | 41    | 65    | ✅     |
        | Data Stores | 31     | 0      | 0       | 22    | 31    | ✅     |
        | Analytics   | 1      | 0      | 1       | 0     | 2     | ✅     |
        | Release     | 5      | 0      | 0       | 5     | 5     | ✅     |
        | Monitor     | 8      | 0      | 0       | 7     | 8     | ✅     |
        | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
        +-------------+--------+--------+---------+-------+-------+--------+
        | Total       | 337    | 0      | 29      | 263   | 366   | ✅     |
        +-------------+--------+--------+---------+-------+-------+--------+
      • Archish Thakkar added 833 commits

        added 833 commits

        • ee9eacc4...ef9bb070 - 832 commits from branch gitlab-org:master
        • a7b0215b - Merge branch 'master' of gitlab.com:gitlab-community/gitlab into...

        Compare with previous version

      • Archish Thakkar reset approvals from @jayswain, @eduardobonet, and @ddieulivol by pushing to the branch

        reset approvals from @jayswain, @eduardobonet, and @ddieulivol by pushing to the branch

      • Eduardo Bonet approved this merge request

        approved this merge request

      • Eduardo Bonet resolved all threads

        resolved all threads

      • added pipelinetier-2 label and removed pipelinetier-3 label

      • David Dieulivol approved this merge request

        approved this merge request

      • David Dieulivol resolved all threads

        resolved all threads

      • David Dieulivol enabled an automatic merge when all merge checks for a7b0215b pass

        enabled an automatic merge when all merge checks for a7b0215b pass

      • David Dieulivol mentioned in merge request !154540 (merged)

        mentioned in merge request !154540 (merged)

      • Hey there @ramistry, could you please help @archish27 out?

        This message was generated automatically. You're welcome to improve it.

      • requested review from @ramistry

      • David Dieulivol removed review request for @jayswain and @ramistry

        removed review request for @jayswain and @ramistry

      • David Dieulivol canceled the automatic merge

        canceled the automatic merge

      • David Dieulivol requested review from @alexbuijs

        requested review from @alexbuijs

      • :tools: Generated by gitlab_quality-test_tooling.


        :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

        Click to expand
        Job File Name Duration Expected duration
        #6969225215 ee/spec/models/epic_spec.rb#L953 Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 48.54 s < 45.4 s
        #6970988628 ee/spec/models/epic_spec.rb#L953 Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 52.65 s < 45.4 s
        #6971000314 ee/spec/models/epic_spec.rb#L953 Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 46.53 s < 45.4 s
        #6971000441 ee/spec/models/epic_spec.rb#L953 Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 47.38 s < 45.4 s
        #6970988522 ee/spec/models/epic_spec.rb#L953 Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 59.48 s < 45.4 s
        #6972864139 ee/spec/models/epic_spec.rb#L953 Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 52.71 s < 45.4 s
      • A deleted user added rspec:slow test detected label
      • Author Contributor

        Hey @alexbuijs if you don't mind can you please review this MR on priority? Thanks :ping_pong:

      • requested review from @jarka

      • @jarka @alexbuijs @eduardobonet @ddieulivol, this Community contribution is ready for review.

        • Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
        • If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

        This message was generated automatically. You're welcome to improve it.

      • requested review from @jayswain

      • Jarka Košanová approved this merge request

        approved this merge request

      • added pipelinetier-3 label and removed pipelinetier-2 label

      • Jarka Košanová resolved all threads

        resolved all threads

      • Jarka Košanová enabled an automatic merge when all merge checks for a7b0215b pass

        enabled an automatic merge when all merge checks for a7b0215b pass

      • @archish27, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

        1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
        2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

        Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

        Thanks for your help! :heart:

        This message was generated automatically. You're welcome to improve it.

      • mentioned in commit 5e79752f

      • added workflowstaging label and removed workflowcanary label

      • Please register or sign in to reply
        Loading