Fix Lint/AmbiguousOperatorPrecedence 4 offenses
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do and why?
Fix Lint/AmbiguousOperatorPrecedence 4 offenses
Changelog: other EE: true
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
Hey @archish27!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can make AI-generated contributions to GitLab! If you use AI-generated content please check the box added to the top of your merge request description.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @archish27
This merge request will be counted as part of the running Hackathon!
Find yourself in the Hackathon Leaderboard or check out the Hackathon page for more information!
This message was generated automatically. You're welcome to improve it.
This merge request will be counted as part of the running Hackathon!
Find yourself in the Hackathon Leaderboard or check out the Hackathon page for more information!
This message was generated automatically. You're welcome to improve it.
added Hackathon label
3 Warnings This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Labels missing: please ask a reviewer or maintainer to add backend to this merge request. Reviewer roulette
Category Reviewer Maintainer backend @imand3r
(UTC-7)
@mkozono
(UTC-10)
~"Backend Static Code Analysis" Reviewer review is optional for ~"Backend Static Code Analysis" @nao.hashizume
(UTC-7)
~"Tooling" Reviewer review is optional for ~"Tooling" @ddieulivol
(UTC+2)
groupauthorization Reviewer review is optional for groupauthorization @hmehra
(UTC+10)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded Engineering Productivity label
mentioned in issue gitlab-org/quality/triage-reports#17450 (closed)
added typemaintenance label
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
Hi Coach
@daniel-murphy
, this Community contribution is ready for review or needs your coaching.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
requested review from @daniel-murphy
added Leading Organization label
mentioned in issue gitlab-org/quality/triage-reports#17608 (closed)
- Resolved by Eduardo Bonet
added workflowin dev label and removed workflowready for review label
added backend label
added pipelinetier-1 label
added 5101 commits
-
22310fd1...a4eff1b5 - 5099 commits from branch
gitlab-org:master
- 4dc27cdb - Merge branch 'master' of gitlab.com:gitlab-community/gitlab into...
- ee9eacc4 - Merge branch 'master' of gitlab.com:gitlab-community/gitlab into...
-
22310fd1...a4eff1b5 - 5099 commits from branch
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer backend @janis
(UTC+2)
@eduardobonet
(UTC+2)
~"Tooling" Reviewer review is optional for ~"Tooling" @splattael
(UTC+2)
groupauthorization Reviewer review is optional for groupauthorization @jarka
(UTC+2)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Danger Botrequested review from @daniel-murphy
requested review from @eduardobonet
removed review request for @daniel-murphy
changed milestone to %17.1
added pipeline:mr-approved label
requested review from @hmehra, @ddieulivol, and @nao.hashizume
- Resolved by Eduardo Bonet
@eduardobonet
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-2 label and removed pipelinetier-1 label
removed review request for @nao.hashizume
added pipelinetier-3 label and removed pipelinetier-2 label
3 Warnings 43af5584: The commit subject must not start with a space. For more information, take a look at our Commit message guidelines. This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer backend @janis
(UTC+2)
@eduardobonet
(UTC+2)
~"Tooling" Reviewer review is optional for ~"Tooling" @ddieulivol
(UTC+2)
groupauthorization Reviewer review is optional for groupauthorization @alexbuijs
(UTC+2)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a7b0215bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 54 | 0 | 2 | 47 | 56 | ✅ | | Verify | 30 | 0 | 2 | 29 | 32 | ✅ | | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Create | 125 | 0 | 10 | 93 | 135 | ✅ | | Govern | 64 | 0 | 1 | 41 | 65 | ✅ | | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | | Analytics | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 7 | 8 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 337 | 0 | 29 | 263 | 366 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 833 commits
-
ee9eacc4...ef9bb070 - 832 commits from branch
gitlab-org:master
- a7b0215b - Merge branch 'master' of gitlab.com:gitlab-community/gitlab into...
-
ee9eacc4...ef9bb070 - 832 commits from branch
reset approvals from @jayswain, @eduardobonet, and @ddieulivol by pushing to the branch
- Resolved by David Dieulivol
Hey @jayswain @eduardobonet @ddieulivol there were merge conflicts I have resolved
can you please review & merge? Targeting this MR to be merged before 30th May. Thanks
added pipelinetier-2 label and removed pipelinetier-3 label
enabled an automatic merge when all merge checks for a7b0215b pass
mentioned in merge request !154540 (merged)
@gitlab-bot help
Hey there @ramistry, could you please help @archish27 out?
This message was generated automatically. You're welcome to improve it.
requested review from @ramistry
- Resolved by Jarka Košanová
Hey @ddieulivol @ramistry can you please remove reviewers @jayswain & @ramistry I believe auto-merge will not happen.
requested review from @alexbuijs
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #6969225215 ee/spec/models/epic_spec.rb#L953
Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 48.54 s < 45.4 s #6970988628 ee/spec/models/epic_spec.rb#L953
Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 52.65 s < 45.4 s #6971000314 ee/spec/models/epic_spec.rb#L953
Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 46.53 s < 45.4 s #6971000441 ee/spec/models/epic_spec.rb#L953
Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 47.38 s < 45.4 s #6970988522 ee/spec/models/epic_spec.rb#L953
Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 59.48 s < 45.4 s #6972864139 ee/spec/models/epic_spec.rb#L953
Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 52.71 s < 45.4 s - A deleted user
added rspec:slow test detected label
added pipeline:skip-undercoverage label
Hey @alexbuijs if you don't mind can you please review this MR on priority? Thanks
@gitlab-bot ready @jarka
added workflowready for review label and removed workflowin dev label
requested review from @jarka
@jarka
@alexbuijs
@eduardobonet
@ddieulivol
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
@gitlab-bot ready @jayswain
requested review from @jayswain
- Resolved by Jarka Košanová
added pipelinetier-3 label and removed pipelinetier-2 label
enabled an automatic merge when all merge checks for a7b0215b pass
@archish27, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 5e79752f
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3098 (merged)