Update ListboxHelper to adhere to Pajamas style
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do and why?
Fixes: #417800 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
See !151151 (comment 1911124165).
How to set up and validate locally
- Visit some of the places this helper is used:
- project forks page http://gdk.test:3000/gitlab-org/gitlab-test/-/forks
- project starrers page http://gdk.test:3000/gitlab-org/gitlab-test/-/starrers
- Ensure the dropdown looks correct. Ideally, load the page with JavaScript disabled, since the markup this changes is completely replaced by Vue components once JS is executed.
- Bonus points: compare DOM structure with a real listbox (just the button and parent element, not the menu).
Merge request reports
Activity
Hey @sbin64!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can make AI-generated contributions to GitLab! If you use AI-generated content please check the box added to the top of your merge request description.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @sbin64
This merge request will be counted as part of the running Hackathon!
Find yourself in the Hackathon Leaderboard or check out the Hackathon page for more information!
This message was generated automatically. You're welcome to improve it.
added Hackathon label
added linked-issue label
added docs-only label
@gitlab-bot ready
@sbin64 this merge request currently contains no changes. If you have made changes, the diff may not yet be ready.
We will wait 5 minutes before assigning a reviewer.
If no reviewer is assigned, please use the command:
@gitlab-bot help
.This message was generated automatically. You're welcome to improve it.
3 Warnings This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Labels missing: please ask a reviewer or maintainer to add frontend, backend to this merge request. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @jon_jenkins
(UTC-5)
@hustewart
(UTC-4)
frontend @thomasrandolph
(UTC-6)
@anna_vovchenko
(UTC+3)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved docs-only label
added workflowready for review label and removed workflowin dev label
Hi Coach
@jannik_lehmann
, this Community contribution is ready for review or needs your coaching.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
requested review from @jannik_lehmann
- Resolved by Saan A
Thanks for your contribution @sbin64 !
I'm not sure in this case if this is really what we need. If I look at the changes in this MR, this button is actually styled as a link and therefore is one of the exceptions described in: &8153before changes after changes I would recommend to close this MR, and to close: #417901 (closed) leaving a comment that this button is styled as a link and therefore should be left as is. What do you think?
removed review request for @jannik_lehmann