Skip to content

Fix focus-visibility for vulnerability actions

What does this MR do?

When navigating through the security dashboard using the keyboard, the action buttons for a given vulnerability stay hidden, even when they have focus.

This MR changes the responsible CSS-selector from using :focus to :focus-within so the row of buttons is set to be visible whenever an element inside has focus.

Note: The pseudo-selector is not supported by IE and only recent versions of Edge.

Before

security_dashboard_vuln_row_action_buttons_focus

After

security_dashboard_vuln_row_action_buttons_focus_after

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David Pisek

Merge request reports