Skip to content
Snippets Groups Projects

Remove Vue set for vue 3 migration from protected environments

Merged Artur Fedorov requested to merge 452467-vue3-migration-protected-environment into master
1 unresolved thread

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR partially resolves #452467 (closed)

What was cleaned up from epic:

  1. Remove Vue.set

Vue set is no longer supported in VUE 3

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

NO VISUAL CHANGES

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Checkout branch
  2. Run test locally
  3. Or just check in pipeline
  4. Run it also with VUE_VERSION=3 yarn jest --watch 

You can check via UI

  1. Go to project
  2. Settings -> CI/CD
  3. Protected environments
  4. Try to protect/unprotect environment

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Artur Fedorov added 448 commits

    added 448 commits

    Compare with previous version

  • @arfedoro Some end-to-end (E2E) tests should run based on the stage label.

    Please start the manual:e2e-test-pipeline-generate job in the prepare stage and wait for the tests in the follow-up:e2e:package-and-test-ee pipeline to pass before merging this MR. Do not use Auto-merge, unless these tests have already completed successfully, because a failure in these tests do not block the auto-merge. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

    To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

    E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

    Once done, apply the :white_check_mark: emoji on this comment.

    Team members only: for any questions or help, reach out on the internal #test-platform Slack channel.

  • added 1 commit

    Compare with previous version

  • Artur Fedorov added 232 commits

    added 232 commits

    Compare with previous version

  • Miguel Rincon enabled an automatic merge when all merge checks for ae05bc62 pass

    enabled an automatic merge when all merge checks for ae05bc62 pass

  • Miguel Rincon approved this merge request

    approved this merge request

  • Miguel Rincon resolved all threads

    resolved all threads

  • Miguel Rincon mentioned in commit 8d62fcbe

    mentioned in commit 8d62fcbe

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading