Skip to content

Remove unused Usage Quotas tab initiation js files

Sheldon Led requested to merge led/remove-unused-index-files into master

What does this MR do and why?

These files should've been removed in Cleanup Feature Flag: usage_quotas_for_all_edit... (!149041 - merged)

With the Feature Flag being removed, Usage Quotas tabs don't use these file to render anymore. The render happens with:

  1. Div with id #js-usage-quotas-view in the haml file: Group, Project, Profile
  2. This div will be selected to load the Usage Quotas View App: Group, Project, Profile,
  3. The Usage Quotas View App Initializator will load tab_metadata depending on the view_type (Group, Project, or Profile)
    1. These metadata differ per view type, and per GitLab distribution (e.g. CE group_view_metadata vs EE group_view_metadata
  4. Each Page view metadata will include the necessary tab initiator, that does the job that the files being deleted in this MR used to do, example: Pipelines tab_metadata

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. Simply do a project search and notice that these files aren't imported/invoked anywhere
  2. Visit Usage Quotas Pages and notice they load fine:
    1. Group Usage Quotas: https://gitlab.com/groups/<group-id>/-/usage_quotas
    2. Project Usage Quotas: https://gitlab.com/<group-id>/<project-id>/-/usage_quotas
    3. Profile/User Namespace Usage Quotas: https://gitlab.com/-/profile/usage_quotas
Edited by Sheldon Led

Merge request reports