Skip to content

Add a new detailed merge status when an MR is temporarily unapproved

What does this MR do and why?

When we push, we temporarily unapprove the MR in order to give the approvals to sync. The problem comes when the detailed merge status is going to returned as not_approved which is not strictly true. Instead we create a new status to return that gives the user information that the approvals are syncing.

To Test:

  • Create an MR
  • Check the network request response which contains detailedMergeStatus
  • Open in a new tab
  • Push a new change
  • Reload the graphql tab and it will be APPROVALS_SYNCING
  • Wait 10 seconds
  • The state should now be correct

Screenshot 2024-04-26 at 14.46.45.png

Screenshot 2024-04-26 at 14.47.44.png

Related to #418216 (closed)

Edited by Marc Shaw

Merge request reports