Skip to content

Add analytics instrumentation review when InternalEvents are used

Michał Wielich requested to merge michw-internal-review into master

What does this MR do and why?

Add automatic analytics instrumentation review when InternalEvents are used. As visible with !147246 (merged) , without it, some MRs can use internal events but still pass without our team's review.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Make branch based of of this branch
  2. Add changes that include an InternalEvents.track_event() backend or InternalEvents.trackEvent() frontend call
  3. Commit them, push them and create a new MR
  4. The Danger comment should recommend an analytics instrumentation team review.

Merge request reports