Skip to content

Removes link to log viewer

Miguel Rincon requested to merge mrincon-remove-link-to-log-viewer into master

What does this MR do and why?

While the log viewer can load logs in a simple environment, when jobs are archived and moved to a CDN the log cannot be loaded anymore.

This change removes the link to access the viewer while we fix the issue.

Changelog: changed

Note: The viewer stays available under <job_url>/viewer, by removing the link, we reduce confusion. See !145499 (merged)

Details

Looks like releasing the log viewer was a bit premature.

In gitlab.com we use a CDN to display our logs, with a different domain name cdn.artifacts.gitlab-static.net. This prevents our client side fetch due to XSS protection.

I'll have to circle back and see what's the best way to fetch them without many changes: I'd rather avoid CSP additions.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Visit a log which goes over the 500kb limit.
  2. Ensure there is no " view full log" link in the top bar
Edited by Miguel Rincon

Merge request reports