Skip to content

Update CODEOWNERS for secrets push check to require SD group review

Ahmed Hemdan requested to merge update-codeowners-for-secrets-check-to-require-sd-group-review into master

What does this MR do and why?

This is basically the same as !143593 (merged) but changes ownership to groupsecret detection due to the recent group split.

It updates CODEOWNERS to require approvals from groupsecret detection for any changes related to secrets push check.

Please read this section for more on the why.

As part of the process, I also have to invite the @gitlab-org/secure/secret-detection group to the gitlab-org/gitlab project as a members:

For approval to be required, groups as Code Owners must have a direct membership (not inherited membership) in the project. Approval can only be optional for groups that inherit membership. Members in the Code Owners group also must be direct members, and not inherit membership from any parent groups.

Therefore, if any of you receives notifications about being added as members to the gitlab-org/gitlab project, this is the reason.

MR acceptance checklist

I have evaluated this MR against the MR acceptance checklist.

Edited by Ahmed Hemdan

Merge request reports