Skip to content

Modify injectVueAppBreadcrumbs to support new Vue page breadcrumbs

Thomas Hutterer requested to merge 358113-inject-dynamic-next-to-static-vue-breadcrumbs into master

What does this MR do and why?

Related to #358113 (closed).

This is the last missing piece to move our vue-page-breadcrumbs feature out of wip state.

With this MR, the new Vue breadcrumbs now support the existing injectVueAppBreadcrumbs which allows pages to control the trailing breadcrumbs (Vue-router multi-page apps, like the Package Registry).

Why is the feature flag type not changed yet?

Currently this feature flag is disabled in our specs. Because of a change in testids, a bunch of feature specs would currently fail if it was enabled. I'm working on a follow-up MR to this one here, that will enable the FF in all specs, and change its type to gitlab_com_derisk at the same time.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

FF disabled (this MR & master) FF enabled on master FF enabled on this MR
image image image

How to set up and validate locally

  • Feature.enable(:vue_page_breadcrumbs)
  • Go to pages that use the injectVueAppBreadcrumbs mechanism, for example:
    • the Package Registty. You'll have to upload at least one package to see more than just its empty index page. I usually push a ruby gem.
    • the Container Registry. Same procedure, push a image to see a "sub page" and its breadcrumbs.
  • Compare breadcrumbs to how they behaved without the FF. Nothing should be missing.
  • Play with resizing your window and observe resize behavior.
Edited by Thomas Hutterer

Merge request reports