Improve add_column documentation
What does this MR do and why?
This MR updates our database documentation to leverage if_not_exists
instead of using column_exists?.
- add_column(:users, :updated_at, :datetime) unless column_exists?(:users, :updated_at)
+ add_column(:users, :updated_at, :datetime, if_not_exists: true)
Merge request reports
Activity
changed milestone to %17.0
assigned to @morefice
added workflowin review label and removed workflowproduction label
removed pipeline:mr-approved label
added databasereview pending label and removed databasereviewed label
@dgruzd can you review this MR please?requested review from @dgruzd
- A deleted user
2 Messages This merge request adds or changes files that require a review from the Database team. This MR contains docs in the /doc/development directory, but any Maintainer (other than the author) can merge. You do not need tech writer review. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Alper Akgun
added databasereviewed label and removed databasereview pending label
mentioned in epic &7522
@a_akgun, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
Hello @morefice
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.