Skip to content

Add `destroy` to bulk_database_action dangerbot suggestions

Joe Woodward requested to merge chore/update-bulk-db-suggestor into master

What does this MR do and why?

Add destroy to bulk_database_action dangerbot suggestions

We already check if the code includes destroy but the suggestion comment did not include it which can lead to confusion.

New message states:

When using update, upsert, delete, destroy, update_all, upsert_all, delete_all or destroy_all you must include the full database query and query execution plan in the merge request description, and request a database review.

This comment can be ignored if the object is not an ActiveRecord class, since no database query would be generated.


For more information, see Database Review documentation.

Edited by Joe Woodward

Merge request reports