Skip to content

Include itemprop attribute in project avatar component

Andrew Smith requested to merge espadav8/gitlab:457837-include-itemprop-image-in-avatar-component into master
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

In a number of places in the HAML templates for avatars we include the itemprop attribute, for example;

It was mentioned by @vvempati in another MR of mine (!147906 (diffs, comment 1832971734)) that I missed passing it into the component, however, if we do want to keep the prop around from the HAML port to Vue, rather than doing it for each component usage it should probably belong in the ProjectAvatar component itself.

Itemprop@MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/itemprop

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visible changes

How to set up and validate locally

  1. Visit a page using the ProjectAvatar component and check in the developer tools that itemprop="image" is visible in the DOM

Closes: #457837 Ref: #457848

Edited by Andrew Smith

Merge request reports