Remove Vue set for vue 3 migration from cycle_analytics
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR partially resolves #452467 (closed)
What was cleaned up from epic:
- Remove
Vue.set
Vue set is no longer supported in VUE 3
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
NO VISUAL CHANGES
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout branch
- Run test locally
- Or just check in pipeline
- Run it also with
VUE_VERSION=3 yarn jest --watch
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %17.1
assigned to @arfedoro
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @marina.mosti
(UTC+2, same timezone as author)
@anna_vovchenko
(UTC+3, 1 hour ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Phil Hughes
@arfedoro - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8dac9527 and 1d0b8792
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.31 MB 4.31 MB - -0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 8dac9527. So we have used data from: 3660cb7c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Artur Fedorov
@robyrne could you please review this MR?
requested review from @robyrne
added pipeline:mr-approved label
- Resolved by Phil Hughes
@robyrne
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1d0b8792expand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
@arfedoro Some end-to-end (E2E) tests should run based on the stage label.
Please start the
manual:e2e-test-pipeline-generate
job in theprepare
stage and wait for the tests in thefollow-up:e2e:package-and-test-ee
pipeline to pass before merging this MR. Do not use Auto-merge, unless these tests have already completed successfully, because a failure in these tests do not block the auto-merge. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#test-platform
Slack channel.enabled an automatic merge when all merge checks for 1d0b8792 pass
added typemaintenance label
mentioned in commit 6c7197f9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label