Skip to content

Move AiRelatedSettingsChangedEvent

Joanna Tomassoni requested to merge gitlab-community/gitlab:444224-move-call-to-airelatedsettingschangedevent into master
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do and why?

This moves the call to the AiRelatedSettingsChangedEvent from NamespaceSetting::AssignAttributesServices to EE::Groups::UpdateService. In the group updating workflow, it's possible for the update to hit NamespaceSetting::AssignAttributesServices, but later get to Groups::UpdateService, fail some validation logic, and not actually get updated.

Thus, previously, the AiRelatedSettingsChangedEvent was potentially being created for changes that we not actually persisted. Moving the event to Groups::UpdateService means that the AiRelatedSettingsChangedEvent will only be created after changes are persisted.

#444224

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Joanna Tomassoni

Merge request reports