Modify breadcrumbs text on the creation of new entities page
-
Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA
What does this MR do and why?
Modify breadcrumbs text to be more intuitive on the creation of new entities page
Related to: #432868
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Visit
http://127.0.0.1:3000/flightjs/Flight/-/environments/new
and breadcrumbs should now show 'New Environment' - Visit
http://127.0.0.1:3000/flightjs/Flight/-/tags/new
and breadcrumbs should now show 'New Tag' - Visit
http://127.0.0.1:3000/flightjs/Flight/-/releases/new
and breadcrumbs should now show 'New Release'
Merge request reports
Activity
Hey @jzeng88!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can make AI-generated contributions to GitLab! If you use AI-generated content please check the box added to the top of your merge request description.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @jzeng88
This merge request will be counted as part of the running Hackathon!
Check out the Hackathon page for more information!
This message was generated automatically. You're welcome to improve it.
added Hackathon label
added linked-issue label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. Reviewer roulette
Category Reviewer Maintainer backend @bhrai
(UTC+2)
@brodock
(UTC+2)
frontend @sheldonled
(UTC+1)
@djadmin
(UTC+5.5)
test for spec/features/*
@bhrai
(UTC+2)
Maintainer review is optional for test for spec/features/*
UX @emilybauman
(UTC-4)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@gitlab-bot ready @bhrai @viktomas
added workflowready for review label and removed workflowin dev label
@viktomas
@bhrai
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/quality/triage-reports#17374 (closed)
- Resolved by Justin Ho Tuan Duong
Thank you for the contribution @jzeng88, the code change looks good.
@emilybauman I saw you discussing this change in Make breadcrumbs text more intuitive on the cre... (#432868), Most of the "new" pages that I checked use only "New" in breadcrumbs. Are we OK with making this change in a handful of places and not the others? I'm just double-checking.
added pipeline:mr-approved label
- Resolved by Justin Ho Tuan Duong
@bhrai
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
mentioned in issue gitlab-org/quality/triage-reports#17375 (closed)
added groupenvironments label
added devopsdeploy sectioncd labels
added featureenhancement label
added typefeature label
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Zeng
requested review from @justin_ho and removed review request for @djadmin
added 2 commits
added UX label
- Resolved by Gabriel Mazetto
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. You're welcome to improve it.
removed review request for @justin_ho
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. Reviewer roulette
Category Reviewer Maintainer backend @bauerdominic
(UTC+2)
@ifarkas
(UTC+2)
frontend @robyrne
(UTC+2)
@vitallium
(UTC+2)
test for spec/features/*
@bauerdominic
(UTC+2)
Maintainer review is optional for test for spec/features/*
UX @emilybauman
(UTC-4)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 0ba89799expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 32 | 0 | 1 | 0 | 33 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Data Stores | 22 | 0 | 4 | 0 | 26 | ✅ | | Create | 89 | 0 | 8 | 0 | 97 | ✅ | | Plan | 50 | 0 | 2 | 0 | 52 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Package | 16 | 0 | 12 | 0 | 28 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 289 | 0 | 28 | 0 | 317 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @emilybauman
removed review request for @emilybauman
added 1394 commits
-
231c83f7...423657e3 - 1393 commits from branch
gitlab-org:master
- 0ba89799 - Merge branch 'master' into 432868-make-breadcrumbs-text-more-intuitive
-
231c83f7...423657e3 - 1393 commits from branch
enabled an automatic merge when all merge checks for 0ba89799 pass
- Resolved by Justin Ho Tuan Duong
@jzeng88 Thanks for contributing to GitLab! I've set it to Merge when Pipeline Succeeds
@brodock, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
@jzeng88, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 822814c7
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#6157 (closed)
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
changed milestone to %17.0
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3058 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label
added Leading Organization label