Skip to content
Snippets Groups Projects

Modify breadcrumbs text on the creation of new entities page

All threads resolved!
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do and why?

Modify breadcrumbs text to be more intuitive on the creation of new entities page

Related to: #432868

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
tags_before image
releases_before image
Screenshot_2024-04-22_at_4.12.04_PM image

How to set up and validate locally

  1. Visit http://127.0.0.1:3000/flightjs/Flight/-/environments/new and breadcrumbs should now show 'New Environment'
  2. Visit http://127.0.0.1:3000/flightjs/Flight/-/tags/new and breadcrumbs should now show 'New Tag'
  3. Visit http://127.0.0.1:3000/flightjs/Flight/-/releases/new and breadcrumbs should now show 'New Release'
Edited by Justin Zeng

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dheeraj Joshi requested review from @justin_ho and removed review request for @djadmin

    requested review from @justin_ho and removed review request for @djadmin

  • Justin Zeng added 2 commits

    added 2 commits

    Compare with previous version

  • Justin Zeng changed the description

    changed the description

  • added UX label

  • Justin Ho Tuan Duong approved this merge request

    approved this merge request

  • Justin Ho Tuan Duong removed review request for @justin_ho

    removed review request for @justin_ho

  • 2 Warnings
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    :warning: This merge request does not refer to an existing milestone.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @bauerdominic profile link current availability (UTC+2) @ifarkas profile link current availability (UTC+2)
    frontend @robyrne profile link current availability (UTC+2) @vitallium profile link current availability (UTC+2)
    test for spec/features/* @bauerdominic profile link current availability (UTC+2) Maintainer review is optional for test for spec/features/*
    UX @emilybauman profile link current availability (UTC-4) Maintainer review is optional for UX

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 0ba89799

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 32     | 0      | 1       | 0     | 33    | ✅     |
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Data Stores | 22     | 0      | 4       | 0     | 26    | ✅     |
    | Create      | 89     | 0      | 8       | 0     | 97    | ✅     |
    | Plan        | 50     | 0      | 2       | 0     | 52    | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Package     | 16     | 0      | 12      | 0     | 28    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 289    | 0      | 28      | 0     | 317   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Emily Bauman requested review from @emilybauman

    requested review from @emilybauman

  • Emily Bauman approved this merge request

    approved this merge request

  • Emily Bauman removed review request for @emilybauman

    removed review request for @emilybauman

  • Justin Zeng added 1394 commits

    added 1394 commits

    • 231c83f7...423657e3 - 1393 commits from branch gitlab-org:master
    • 0ba89799 - Merge branch 'master' into 432868-make-breadcrumbs-text-more-intuitive

    Compare with previous version

  • Gabriel Mazetto enabled an automatic merge when all merge checks for 0ba89799 pass

    enabled an automatic merge when all merge checks for 0ba89799 pass

  • Gabriel Mazetto approved this merge request

    approved this merge request

  • Justin Ho Tuan Duong resolved all threads

    resolved all threads

  • @brodock, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • @jzeng88, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • mentioned in commit 822814c7

  • added workflowstaging label and removed workflowcanary label

  • changed milestone to %17.0

  • Please register or sign in to reply
    Loading