Skip to content

Rubocop: Fixes graphql resolver method length warning

Nicholas requested to merge gitlab-community/gitlab:nwittstruck-fix-rubocop-graqphl-resolver-method-length into master
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do and why?

This MR wants to resolve some rubocop warnings, specifically the warning that the method length is too long for GraphQL resolver methods.

Included are two fixes:

  • /app/graphql/types/ci/runner_type.rb: I've reduced the method length in runner_typ.rb#project_count so that it fits within the limit.
  • /.rubocop_todo/graphql/resolver_method_length.yml: I've removed an outdated exclusion for detailed_status_type.rb, as well as runner_type.rb

👋 from b310

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

None, as this fixes rubocop warnings and should show up in the CI pipeline.

How to set up and validate locally

  • Run rubocop
Edited by Nicholas

Merge request reports